Skip to content

8202100: Merge vm/share/InMemoryJavaCompiler w/ jdk/test/lib/compiler/InMemoryJavaCompiler #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8202100: Merge vm/share/InMemoryJavaCompiler w/ jdk/test/lib/compiler/InMemoryJavaCompiler #3606

wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented May 22, 2025 •
edited by openjdk bot
Loading

I backport this test change as it also goes to 17.0.17-oracle.

This needed some trivial resolves:

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/RedefineCallerClassTest.javaCommits on Nov 16, 2021
Was added by "https://bugs.openjdk.org/browse/JDK-8276184: Exclude lambda proxy class from the CDS archive if its caller class is excluded". Omitted.

test/hotspot/jtreg/runtime/cds/appcds/redefineClass/RedefineRunningMethods_Shared.java
Resolved Copyright

ptest/hotspot/jtreg/vmTestbase/metaspace/staticReferences/StaticReferences.java
Resolved import.

test/hotspot/jtreg/vmTestbase/nsk/jvmti/RedefineClasses/StressRedefine.java
Resolved Copyright

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8202100 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8202100: Merge vm/share/InMemoryJavaCompiler w/ jdk/test/lib/compiler/InMemoryJavaCompiler (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3606/head:pull/3606
$ git checkout pull/3606

Update a local copy of the PR:
$ git checkout pull/3606
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3606/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3606

View PR using the GUI difftool:
$ git pr show -t 3606

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3606.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 22, 2025 •
edited
Loading

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8202100: Merge vm/share/InMemoryJavaCompiler w/ jdk/test/lib/compiler/InMemoryJavaCompiler

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7404ddf24a162cff445cd0a26aec446461988bc8 8202100: Merge vm/share/InMemoryJavaCompiler w/ jdk/test/lib/compiler/InMemoryJavaCompiler May 22, 2025
@openjdk
Copy link

openjdk bot commented May 22, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 22, 2025
@mlbridge
Copy link

mlbridge bot commented May 22, 2025

Webrevs

@openjdk openjdk bot added the approval label May 23, 2025
@GoeLin
Copy link
Member Author

GoeLin commented May 26, 2025

Thanks for the review!

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 26, 2025
@GoeLin
Copy link
Member Author

GoeLin commented May 27, 2025

/integrate

@openjdk
Copy link

openjdk bot commented May 27, 2025

Going to push as commit 291b18c.
Since your change was applied there have been 10 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 27, 2025
@openjdk openjdk bot closed this May 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 27, 2025
@openjdk
Copy link

openjdk bot commented May 27, 2025

@GoeLin Pushed as commit 291b18c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8202100 branch May 27, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phohensee phohensee phohensee approved these changes

Assignees
No one assigned
Labels
backport integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GoeLin @phohensee